-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimum and Exact AT Version #1055
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM! Having reviewed a bit of this work already in #997, can confirm the new pieces work as expected. Exciting!
I've left a small suggestion in thread
@@ -23,74 +23,6 @@ import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'; | |||
import DisclosureComponentUnstyled from '../common/DisclosureComponent'; | |||
|
|||
const DisclosureContainer = styled.div` | |||
// Following directives are related to the ManageTestQueue component |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. This should be its own component too probably. (future thought)
); | ||
}; | ||
|
||
const TextThatWontShiftWhenBold = ({ isBold, children: text }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Descriptive!
browserId: ID! | ||
copyResultsFromTestPlanReportId: ID | ||
copyResultsFromTestPlanVersionId: ID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another good catch
To reviewers: In a separate discussion with @alflennik we agreed this now introduces breaking changes around the Test Plan Report status dialog. I've added a Currently #1001 is also expected to branch off of this work. |
Co-authored-by: Howard Edwards <[email protected]>
This includes work to support #791 and #792. Includes the following changes: * #1055 * #1001 * #1065 * #1052 * #1087 * #1098 * #1092 * #1131 * #1124 --------- Co-authored-by: Howard Edwards <[email protected]> Co-authored-by: Paul Clue <[email protected]> Co-authored-by: alflennik <[email protected]>
Adds a new "minimum" and "exact" AT Version picker to the "Add to test queue" UI. This is part of #791.
Note that the test queue status dialog has not yet been updated and is not expected to work.
This PR resolves also conflicts with the development branch that currently prevent merging
can-duplicate-test-plan-reports
. Therefore this diff includes all the changes from that branch. Sorry for the noise. If we usecan-duplicate-test-plan-reports
as a base the number of files changed would actually increase.